Week 13
Project Reflection
This week, my group was focused on finishing their up their PRs and finalizing it so that it can be merged into the master repository. I was addressing some conflict issues to my PR from my maintainer and things were going fine until it didn’t. For the issue I had selected, the goal was to convert one of the javascript files into a typescript file and the specific file I was working on was add_attribute.js. I made some modifications on this file and had submitted a PR. It seems like the time frame that I was modifying the files and adjust to my maintainers feedback, someone else had been working on that issue which was merged into the master branch. I did not realize until later that all the changes I had made was overwritten so the maintainer reviewing my PR did not see any of my changes and rather minor changes I had made from a file. That maintainer left a very rude comment which was unfair and rather for him to seek clarity on what I am trying to do, he was very harsh. Also, it was labeled as a “good first issue” so I think that he could have been patient and closed/mark the issue as completed since someone had gotten to the solution earlier than I did. His comment made me very upset because I had put a lot of effort to fix the issue and make sure the test pass. I do think there was miscommunication and misunderstanding but I can’t do anything about that. I will be exploring other issues to work on for the remaining of the semester.
